Sarkars/backend create tensor #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayantan-nervana
added
🌋 experimental
sayantan-nervana
commented
Dec 6, 2019
kanvi-nervana
approved these changes
Dec 12, 2019
Contributor
kanvi-nervana
left a comment
kanvi-nervana
left a comment
There was a problem hiding this comment.
A minor comment other looks good
| std::shared_ptr<ngraph::runtime::Executable> exec, | ||
| std::vector<tensorflow::PersistentTensor>& tf_output_tensors) { | ||
| auto itr = m_out_persistents.find(exec); | ||
| if (itr == m_out_persistents.end()) { |
Contributor
There was a problem hiding this comment.
Could use PersistentOutputsExist
Contributor
Author
There was a problem hiding this comment.
Then I'd be doing 2 searches. One in PersistentOutputsExist and one in again to actually return the item. Right now I do only one search to find the appropriate iterator
| std::shared_ptr<ngraph::runtime::Executable> exec, | ||
| std::vector<tensorflow::PersistentTensor> persistent_tensors) { | ||
| auto itr = m_out_persistents.find(exec); | ||
| if (itr != m_out_persistents.end()) { |
Contributor
There was a problem hiding this comment.
Could use PersistentOutputsExist
Contributor
|
Please look into the failing pipelines |
Contributor
Author
|
sayantan-nervana
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For certain backends (even if their executable can create tensors), use backends to create tensors