sarkars/Move all maps #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayantan-nervana
requested review from
bani-intelaipg,
kanvi-nervana,
shresthamalik and
vishakha-nervana
kanvi-nervana
approved these changes
Jan 7, 2020
bani-intelaipg
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to add some new functionality to MarkForClustering(MFC) (in a separate PR). MFC is currently monolithic, with all the maps defined inside it. Therefore we cannot access the maps outside MFC. To add the new functionality, I need access to the maps outside MFC. Hence moving the maps outside.
Also added #ifdef DISTRIBUTED to TFtoNgraphOpMap where needed
Now that the map has moved outside, also added test in opexecutor to ensure that the translated function contains ops present in the TfToNg map. With that test, found that a bunch of gtests fail, which have been fixed now.
Also added "MaximumBroadcasting", (MinimumBroadcasting was present already)