Skip to content

Fix Pad op translation #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Fix Pad op translation #660

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d75b4e
Fix Pad op translation
kanvi-nervana Sep 18, 2020
7b2ad3d
Merge branch 'master' into kanvi/pad-op
adk9 Sep 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions ngraph_bridge/ngraph_builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2265,25 +2265,24 @@ static Status TranslatePadOp(const Node* op,
}

// Set pads_begin & pads_end (from the pad_val_op)
shared_ptr<opset::Constant> pads_begin_node, pads_end_node;
std::vector<int64> paddings;
TF_RETURN_IF_ERROR(GetStaticInputVector(op, 1, static_input_map, &paddings));
NGRAPH_VLOG(6) << op->name() << " pads {" << ng::join(paddings) << "}";
NGRAPH_VLOG(3) << op->name() << " pads {" << ng::join(paddings) << "}";
if (paddings.size() % 2 != 0) {
return errors::InvalidArgument(
"Constant node for paddings does not have an even number of "
"elements");
}
ng::CoordinateDiff pad_begin(paddings.size() / 2);
ng::CoordinateDiff pad_end(paddings.size() / 2);
std::vector<int64> pad_begin(paddings.size() / 2);
std::vector<int64> pad_end(paddings.size() / 2);
for (size_t i = 0; i < paddings.size() / 2; i++) {
pad_begin[i] = paddings[2 * i];
pad_end[i] = paddings[2 * i + 1];
}
pads_begin_node = make_shared<opset::Constant>(
ng::element::i64, ng::Shape{pad_begin.size()}, pad_begin);
pads_end_node = make_shared<opset::Constant>(
ng::element::i64, ng::Shape{pad_end.size()}, pad_end);
auto pads_begin_node = ConstructNgNode<opset::Constant>(
op->name(), ng::element::i64, ng::Shape{pad_begin.size()}, pad_begin);
auto pads_end_node = ConstructNgNode<opset::Constant>(
op->name(), ng::element::i64, ng::Shape{pad_end.size()}, pad_end);

// Create final Op
result_pad_op =
Expand Down