Added noisy analytical expectation. #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeyoo
requested changes
Mar 23, 2021
jaeyoo
reviewed
Mar 23, 2021
| for (const Operation& op : moment.operations()) { | ||
| placeholder.gates.clear(); | ||
| gate_fail = false; | ||
| gate_found = false; |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
tfq.noisemodule with the first callable optfq.noise.expectation, which should behave just like our noiseless op only it supports noisy circuits and requires anum_samplesparameter to indicate how many monte-carlo runs to do.Had to bump the version of qsim in order to work around: quantumlib/qsim#308 as well as quantumlib/qsim#312
Had to make some small tweaks to
qsim_circuit_parser_test.ccfor the noisy case that we missed when we first put things in.Like most of our ops the noisy expectation op has both a small and large version. I recommend reading through the
ComputeLargeand then understanding the parallelization scheme forComputeSmall.Please review closely