Skip to content

Adds tfq.noise.samples op. #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 26, 2021
Merged

Adds tfq.noise.samples op. #518

merged 6 commits into from
Mar 26, 2021

Conversation

@MichaelBroughton
Copy link
Collaborator

@MichaelBroughton MichaelBroughton commented Mar 25, 2021

Like with our noisy expectation op, we now have a noisy sampling op. The parallelization for this op was a little bit simpler than with the expectation op.

jaeyoo
jaeyoo reviewed Mar 26, 2021
View reviewed changes
tensorflow_quantum/core/ops/noise/tfq_noisy_samples.cc
Comment on lines +88 to +93
if (!r.ok()) {
p_lock.lock();
parse_status = r;
p_lock.unlock();
return;
}
Copy link
Member

@jaeyoo jaeyoo Mar 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NESTED_FN_STATUS_SYNC after merging #519

Copy link
Member

@jaeyoo jaeyoo Mar 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's merged, please apply this at #519

jaeyoo
jaeyoo approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@jaeyoo jaeyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeyoo jaeyoo merged commit d2dcb96 into master Mar 26, 2021
@jaeyoo jaeyoo deleted the noisy_samples branch March 26, 2021 14:34
@MichaelBroughton MichaelBroughton mentioned this pull request May 6, 2021
Closed
jaeyoo pushed a commit to jaeyoo/quantum that referenced this pull request Mar 30, 2023
@95-martin-orion
Merge pull request tensorflow#518 from lovesegfault/update-deps
2051c71 
    refactor(dev-requirements): use stable black
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaeyoo jaeyoo jaeyoo approved these changes

@zaqqwerty zaqqwerty Awaiting requested review from zaqqwerty

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MichaelBroughton @jaeyoo