Fix #884 by avoiding using --pre with pip install in nightly Cirq compatibility checks
#897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pavol Juhas taught me that the `--pre` flag carries over to other packages installed as transitive dependencies. This can cause unexpected compatibility issues. Switch to using `cirq~=1.0.dev`, which is more limited in its scope and gets us the latest dev release.
mhucka
added
the
area/health
mhucka
changed the title
--pre with pip install in nightly Cirq compatibility checks--pre with pip install in nightly Cirq compatibility checks
MichaelBroughton
approved these changes
Sep 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out the pip
--preflag carries over to other packages that get installed as transitive dependencies. This can cause unexpected compatibility issues. We can avoid using--preby switching to usingcirq~=1.0.dev, which is more limited in its scope and gets us the latest dev version. Doing so ends up resolving issue #884.