-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix issue #21 #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #21 #23
Conversation
|
Can one of the admins verify this patch? |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove space before '('
|
Looks good overall, just one minor comment. In addition to that, please sign the CLA (instructions given by googlebot) and squash all commits after you apply the suggested change. Thanks. |
|
Can one of the admins verify this patch? |
|
Kirilg, thank you for your suggestions very much. But I'm sorry that I'm still waiting for my company's permission to sign the CLA. Could you please wait for a few days? Anyway, I think I can make the commits meet your suggestions first. I have squashed all the commits into the Fix issue #21,support both python 2.7 and python 3.4. Do you think it's OK now? |
|
No problem. Please take a look at https://github.com/tensorflow/serving/blob/master/CONTRIBUTING.md (namely the part that says "If you work for a company that wants to allow you to contribute your work, then you'll need to sign a corporate CLA." along with a link to the corporate CLA page, which I'm guessing is what you did already). Just ping back on this PR once the licensing is sorted out, and I'll merge. With regards to the commits, I still see multiple commits in the "commits" tab (8). Please squash so there's only one. |
|
Can one of the admins verify this patch? |
|
Kirilg, I think I have made some mistakes when I squashed the commits. The PR was closed and recreated at #26. Maybe we can continue the discussion there. Thanks. |
Fix issue #21 to make the example can be built under both python 2.7 and python 3.4.