This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Add default padding values. #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the interest of progressive disclosure of complexity, and good default values, set the padding on the layer types to be `.valid`. This follows the Keras convention as well (https://keras.io/layers/convolutional/).
rxwei
approved these changes
Feb 22, 2019
Contributor
|
I think you missed AvgPool. |
Contributor
Author
|
Good catch. Thanks; fixed! |
jekbradbury
approved these changes
Feb 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the interest of progressive disclosure of complexity, and good default
values, set the padding on the layer types to be
.valid. This followsthe Keras convention as well (https://keras.io/layers/convolutional/).