Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Conversation

@tanmayb123
Copy link
Contributor

a.k.a. "binary_crossentropy" from Keras

a.k.a. "binary_crossentropy" from Keras
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@tanmayb123
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@saeta saeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super great @tanmayb123 ! Thank you very much. In order to help raise the bar for quality, I've asked if you could possibly add a documentation comment to this new loss function. Let me know if that's confusing.

I'm going to mark these changes as approved, however, so you don't block on my subsequent review.

Have a great weekend!

-Brennan

@tanmayb123
Copy link
Contributor Author

Thanks @saeta :)

I've added documentation comments for each loss function.

rxwei and others added 2 commits February 24, 2019 05:06
Co-Authored-By: tanmayb123 <tajymany@gmail.com>
@rxwei
Copy link
Contributor

rxwei commented Feb 24, 2019

Thanks Tanmay!

@rxwei rxwei merged commit ee31b7f into tensorflow:master Feb 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants