-
Notifications
You must be signed in to change notification settings - Fork 138
Add Sigmoid Cross Entropy Loss #24
Conversation
a.k.a. "binary_crossentropy" from Keras
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
saeta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super great @tanmayb123 ! Thank you very much. In order to help raise the bar for quality, I've asked if you could possibly add a documentation comment to this new loss function. Let me know if that's confusing.
I'm going to mark these changes as approved, however, so you don't block on my subsequent review.
Have a great weekend!
-Brennan
|
Thanks @saeta :) I've added documentation comments for each loss function. |
Co-Authored-By: tanmayb123 <tajymany@gmail.com>
|
Thanks Tanmay! |
a.k.a. "binary_crossentropy" from Keras