This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Add Separable Conv1D layer #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Shashi456 A slight nitpick; could you please move the |
rxwei
reviewed
Aug 20, 2019
Contributor
Author
|
@jon-tow alright. But would a layer reorg be appropriate in this PR? There are some format changes in the test file as well, I'll do them as another PR. |
Co-Authored-By: Richard Wei <rxwei@google.com>
Contributor
Author
|
@rxwei done. With this and transposed conv1d and 3d, we are done with basically supporting all convolutional layers :). Extensive testing and more functionality remains. |
rxwei
approved these changes
Aug 20, 2019
rxwei
reviewed
Aug 20, 2019
Contributor
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test and build pass.
Just a question, do we hope to eventually support NCWH formats? A lot of code would need to be modified in that case and I'm realizing that writing these layers.
Could i open an issue for that or would you want to support all layers first before supporting multiple formats?