This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Explicitly qualify LearningPhase.inference to prevent ambiguity err…
#92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to figure out why this is the case though. It wasn't a problem until the Int32 patch. |
|
Did you try |
|
I think I did, but I'm not 100% sure. It seems tests are failing because you haven't updated them. |
…ors. Fixes `swift build` and `swift test`.
dan-zheng
force-pushed
the
fix-swift-build
branch
from
474aba3 to
b3cc7af
Compare
|
Thanks @dan-zheng This is blocking me too. :-) |
|
After merging It seems related to changes introduced in #71. |
|
Darn. We should remove the |
|
I tried removing diff --git a/Sources/DeepLearning/Layer.swift b/Sources/DeepLearning/Layer.swift
index ca2c333..b8f6926 100644
--- a/Sources/DeepLearning/Layer.swift
+++ b/Sources/DeepLearning/Layer.swift
@@ -1276,7 +1276,6 @@ public protocol RNNCell: Layer where Input == RNNCellInput<TimeStepInput, State>
/// The state that may be preserved across time steps.
associatedtype State: Differentiable
/// The zero state.
- @differentiable
var zeroState: State { get }
}
@@ -1303,7 +1302,6 @@ public struct SimpleRNNCell<Scalar: TensorFlowFloatingPoint>: RNNCell {
return TensorShape([1, weight.shape[1]])
}
- @differentiable
public var zeroState: Tensor<Scalar> {
return Tensor(zeros: stateShape)
}
@@ -1349,7 +1347,6 @@ public struct LSTMCell<Scalar: TensorFlowFloatingPoint>: RNNCell {
return TensorShape([1, inputWeight.shape[1]])
}
- @differentiable
public var zeroState: State {
return State(cell: Tensor(zeros: stateShape), hidden: Tensor(zeros: stateShape))
}Narrowing down the bug now. |
|
Looks like zero emission is doing something funny. I do wonder what it's emitting a zero for. |
|
Filed TF-440 with full log. |
|
Fixing now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ors.
Fixes
swift build. Without this change,swift buildfails: