Embedding Projector sprite images appear transparent / use "multiply" blendmode

[tyhenry]

Tensorboard currently uses "multiply" blend-mode to render sprite images in the Embedding Projector. This causes the images to be weirdly transparent, muddy and hard to read:

The cause seems to be
blending: THREE.MultiplyBlending on line 227 in /plugins/projector/vz_projector/scatterPlotVisualizerSprites.ts:

tensorboard/tensorboard/plugins/projector/vz_projector/scatterPlotVisualizerSprites.ts

Line 227 in ea145a4

blending: THREE.MultiplyBlending,

Changing that line to

blending: THREE.NormalBlending,

fixes the issue for me, rendering the sprites with normal opacity:

Could this be updated? Can submit a PR if needed.

[wchargin]

Hi @tyhenry—thanks for the detailed report! That does seem strange to
me, and I’d be inclined to agree with the change that you suggest.
This blend mode change dates back to 2016; I’ve pinged the author
internally to see if there’s any more information that we should have
(Googlers, ref. http://cl/126913512).

I’d suggest opening a PR, as you propose; I’ll let you know if we hear
back from the original author, or just approve+merge after a day or so
if we don’t.