Skip to content

Conversation

orionr
Copy link
Contributor

@orionr orionr commented Sep 12, 2018

A continuation of #1401 to see if we can get CI to compile. Many thanks to @ml7 for making this possible!

This will follow #1451 and #1453

To test (I ran this on a Mac, but Linux is likely similar) run the following

conda create --name notf python=2.7  # Note that we are using a conda environment without TensorFlow to test
conda activate notf
pip install --upgrade pip
conda install protobuf
conda install absl-py
conda install numpy
bazel build tensorboard:tensorboard-notf --verbose_failures
# Sample runs directory comes from `git clone https://github.com/orionr/sample_runs`
./bazel-bin/tensorboard/tensorboard-notf --logdir ~/local/sample_runs

cc @jspisak @jart @martinwicke @nfelt

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@orionr
Copy link
Contributor Author

orionr commented Sep 12, 2018

@ml7 looks like I might need some approval from you here. :) Still, let's see how CI does.

@ml7
Copy link

ml7 commented Sep 12, 2018

ok with PR

@googlebot
Copy link

CLAs look good, thanks!

@orionr orionr force-pushed the build-with-no-tensorflow branch 3 times, most recently from efff065 to 87145b5 Compare September 21, 2018 22:30
@orionr orionr changed the title Option to build without a TensorFlow dependency Add tensorboard-notf target for non-TensorFlow build Oct 18, 2018
@orionr orionr force-pushed the build-with-no-tensorflow branch 7 times, most recently from 9ce5849 to a108733 Compare October 20, 2018 04:03
@orionr
Copy link
Contributor Author

orionr commented Oct 23, 2018

@nfelt this should be ready for review whenever you are. Thanks.

@orionr orionr force-pushed the build-with-no-tensorflow branch from a108733 to 509e72a Compare October 24, 2018 23:56
@orionr
Copy link
Contributor Author

orionr commented Oct 24, 2018

Thanks for the quality review. Updates made.

@orionr orionr force-pushed the build-with-no-tensorflow branch from 509e72a to 2c5060b Compare October 25, 2018 00:00
@orionr orionr force-pushed the build-with-no-tensorflow branch from 2c5060b to 32a2c1d Compare October 29, 2018 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants