-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add tensorboard-notf target for non-TensorFlow build #1418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
@ml7 looks like I might need some approval from you here. :) Still, let's see how CI does. |
ok with PR |
96c5063
to
b8d9b19
Compare
58d393a
to
5eeb0e9
Compare
CLAs look good, thanks! |
efff065
to
87145b5
Compare
9ce5849
to
a108733
Compare
@nfelt this should be ready for review whenever you are. Thanks. |
a108733
to
509e72a
Compare
Thanks for the quality review. Updates made. |
509e72a
to
2c5060b
Compare
2c5060b
to
32a2c1d
Compare
A continuation of #1401 to see if we can get CI to compile. Many thanks to @ml7 for making this possible!
This will follow #1451 and #1453
To test (I ran this on a Mac, but Linux is likely similar) run the following
cc @jspisak @jart @martinwicke @nfelt