Skip to content

Conversation

lanpa
Copy link
Contributor

@lanpa lanpa commented Feb 3, 2019

This modification let pytorch/pytorch@00b8330 use the code inside tensorboard installed by whl file build by bazel.

The generated event file can be rendered correctly by web server build from:
#1663

TODO:

  • rename tensorboardX to something else (keep this name to avoid namespace confusion)
  • correct way to handle plugin protos (now copy that directly)
  • unittests
  • fill license information to pass the test
  • re-enable python2 build/test

Copy link
Contributor

@orionr orionr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nfelt, we're getting closer on the split of tensorboardX into tensorflow/tensorboard and pytorch/pytorch. Would you mind doing a review here and give us some pointers on where the code should live? Much appreciated.

@@ -0,0 +1,25 @@
/* Copyright 2017 The TensorFlow Authors. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,96 @@
/* Copyright 2017 The TensorFlow Authors. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,27 @@
/* Copyright 2017 The TensorFlow Authors. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaces plugin_text.proto and plugin_pr_curve.proto with plugin_data.proto will lead to name confliction. How about using soft links?

@@ -0,0 +1,22 @@
# Description:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of compat/tensorboard can we do compat/writer? @nfelt what are your thoughts on the right naming for this?

"types.proto",
"verifier_config.proto",
"versions.proto",
"plugin_text.proto", # relative dir is not accepted. copt that.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can actually get all three of these from the plugins/ directory.

@orionr
Copy link
Contributor

orionr commented Mar 11, 2019

@lanpa, I just saw that you have direct reference of the protos on your TODO list. Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants