-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add plugin and compat tests for tensorboard-notf #1829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, only the second commit in this pull request
(“Add plugin and compat tests for tensorboard-notf target”) is intended
to be reviewed, yes?
2cb674b
to
bcf4c29
Compare
@wchargin that's correct. I can remove the other if we don't mind test failures right now. What would you prefer? Thank you. |
88ff079
to
2f64e92
Compare
2f64e92
to
8b543f7
Compare
Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the right long-term solution, but for now it improves test coverage, so we can merge once the projector tests are cleaned up per comment below.
Can you also merge in the latest changes from master?
8b543f7
to
1d2dacf
Compare
Need to upgrade bazel to test locally, but just rebased and pushed changes to match the review. Let me know your thoughts and thanks. |
bbba0a5
to
ed22a68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates!
Continuation of #1663
This adds plug and TensorFlow compat tests both locally running and in Travis CI.
cc @nfelt, @lanpa
All the tests can be run with