HParams: Add new selector factory to get runs from experiment ids #6360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHollyer
reviewed
May 3, 2023
| ...state.runMetadata[runId], | ||
| experimentId, | ||
| }); | ||
| }); |
Contributor
There was a problem hiding this comment.
I would prefer something like this:
(state.runsIds[experimentId] || []).forEach(runId => {
if(state.runMetadata[id]) {
runs.push({...state.runMetadata[runId], exprimentId});
}
})
inside the reduce function.
Contributor
Author
There was a problem hiding this comment.
I've updated the formatting to meet someplace in between
JamesHollyer
approved these changes
May 3, 2023
rileyajones
added a commit
to rileyajones/tensorboard
that referenced
this pull request
May 5, 2023
…nsorflow#6360) ## Motivation for features / changes As part of the effort to bring hparams to the time series dashboard a handful of new selectors need to be created. In particular I will be creating a new one to handle runs filtering by moving the logic out of the runs_table_container into the selector layer. This will ensure filtered runs are consistent across the dashboard. ## Technical description of changes This new selector is not meaningfully different from the existing one but the factory allows it to be called with an encapsulated experiment id.
rileyajones
added a commit
that referenced
this pull request
May 9, 2023
## Motivation for features / changes The runs table currently contains the logic to filter runs by hparams, unfortunately, this logic is not shared with the rest of the dashboard and so filtering runs this way does not actually effect what is shown on the dashboard. ## Technical description of changes I moved out a lot of utility functions from the runs table container into common selectors. I then created three selectors 1) `getRenderableRuns` A private selector to help with the readability of `getFilteredRenderableRuns` Gets all runs associated with the provided experiment ids 2) `getFilteredRenderableRuns` Gets all runs associated with the provided experiment ids while accounting for filters. 3) `getFilteredRenderableRunsFromRoute` Retrieves the experiment ids from the route then gets the filtered runs associated with them NOTE: The utility functions are encapsulated in a utils object so that they can be spied on during testing See the PRs leading up to this #6340 #6360 #6361 #6323 #6324 ## Screenshots of UI changes (or N/A) N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
As part of the effort to bring hparams to the time series dashboard a handful of new selectors need to be created. In particular I will be creating a new one to handle runs filtering by moving the logic out of the runs_table_container into the selector layer.
This will ensure filtered runs are consistent across the dashboard.
Technical description of changes
This new selector is not meaningfully different from the existing one but the factory allows it to be called with an encapsulated experiment id.