Skip to content

Remove unused timeSelectionCleared() action. #6389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmd3k merged 1 commit into from
May 17, 2023
Merged

Remove unused timeSelectionCleared() action. #6389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions tensorboard/webapp/metrics/actions/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,10 +220,6 @@ export const cardViewBoxChanged = createAction(
props<{cardId: CardId; userViewBox: Extent | null}>()
);

export const timeSelectionCleared = createAction(
'[Metrics] Linked Time Selection Cleared'
);

export const linkedTimeToggled = createAction(
'[Metrics] Linked Time Enable Toggle',
props<{
Expand Down
6 changes: 0 additions & 6 deletions tensorboard/webapp/metrics/store/metrics_reducers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1341,12 +1341,6 @@ const reducer = createReducer(
cardStateMap: nextCardStateMap,
};
}),
on(actions.timeSelectionCleared, (state) => {
return {
...state,
linkedTimeSelection: null,
};
}),
on(actions.tableEditorTabChanged, (state, {tab}) => {
return {
...state,
Expand Down
12 changes: 0 additions & 12 deletions tensorboard/webapp/metrics/store/metrics_reducers_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3967,18 +3967,6 @@ describe('metrics reducers', () => {
});
});

describe('#timeSelectionCleared', () => {
it('clears linked time selection', () => {
const beforeState = buildMetricsState({
linkedTimeSelection: {start: {step: 4}, end: {step: 4}},
});

const nextState = reducers(beforeState, actions.timeSelectionCleared());

expect(nextState.linkedTimeSelection).toBeNull();
});
});

describe('#rangeSelectionToggled', () => {
it('toggles whether stepSelectorRange is enabled or not', () => {
const state1 = buildMetricsState({
Expand Down