Data Table: refactor data table to use divs instead of html table #6397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHollyer
force-pushed
the
FlexDataTable
branch
from
56b4555 to
b98cecb
Compare
rileyajones
reviewed
May 19, 2023
| width: 100%; | ||
|
|
||
| th { | ||
| header, |
Contributor
There was a problem hiding this comment.
nit: I would prefer you put a class on the header element and then styled that
Contributor
Author
There was a problem hiding this comment.
Done. I also changed this to just be a div.
rileyajones
approved these changes
May 19, 2023
Contributor
rileyajones
left a comment
rileyajones
left a comment
There was a problem hiding this comment.
Given the visual diff tests seem to pass LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
This probably should have been done when the data table was created. html table is generally considered old technology. Building tables with divs is preferred as it allows for more flexibility.
Technical description of changes
Pretty straight forward swap to using display table, table-row, table-column instead of table, tr, td. For the header we use a <header> to wrap it and still use the .col. Because of this header specific logic for .col was moved inside the header object.
I also had to mess around with the row-circle class to get the color circle to align properly because the display is now table-cell instead of flex.
Screenshots of UI changes (or N/A)
New table looks like this.
The only change is that the circle icon moves ever so slightly(to see the difference more clearly googlers can check the screenshot diffs here cl/529831620).
Detailed steps to verify changes work correctly (as executed by you)
A couple CSS queries changes and all the tests pass. I also clicked around and tested functionality in local instance.
Alternate designs / implementations considered (or N/A)
Considered leaving it as is.