HParams: Update scalar card to show columns based on selector #6405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHollyer
approved these changes
May 24, 2023
| }); | ||
| }); | ||
|
|
||
| describe('getSingleSelectionHeaders', () => { |
Contributor
There was a problem hiding this comment.
I think the 'returns all single selection headers' and 'returns all range selection headers' are not needed. It just returns the value and there is no logic to test. That being said. I am ok with these being here.
| getSingleSelectionHeaders, | ||
| getRangeSelectionHeaders, | ||
| (state, singleSelectionHeaders, rangeSelectionHeaders) => { | ||
| return getMetricsCardRangeSelectionEnabled(state, cardId) |
Contributor
There was a problem hiding this comment.
So this cannot be input to the selector because it is a selector with a prop?
| runToSeries | ||
| ); | ||
| store.overrideSelector(getMetricsRangeSelectionEnabled, true); | ||
| store.overrideSelector(getMetricsCardRangeSelectionEnabled, true); |
Contributor
There was a problem hiding this comment.
These test now actually use the getColumnHeadersForCard selector and override the selectors which that selector uses. I kind of like this but is not a pattern we use often. Can we at least add a comment making note of this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
As part of the effort to add hparams into time series we would like to be able to determine the columns to be shown at the selector layer. To that end I have added a new selector which, given a card id, returns the appropriate columns to be shown.
Screenshots of UI changes (or N/A)
Single Selection (its the same)
Range Selection (it's also the same)
