Skip to content

Conversation

@yongtang
Copy link
Member

@yongtang yongtang commented Feb 8, 2021

This PR tries to address the issue raised in #46993 where
incorrect nan value is returned when alpha=None is passed for
tf.keras.layers.LeakyReLU. The nan could be misleading to users.

This PR address the issue and throw out ValueError instead.

This PR fixes #46993.

Signed-off-by: Yong Tang yong.tang.github@outlook.com

…eakyReLU

This PR tries to address the issue raised in 46993 where
incorrect nan value is returned when alpha=None is passed for
tf.keras.layers.LeakyReLU. The nan could be misleading to users.

This PR address the issue and throw out ValueError instead.

This PR fixes 46993.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Feb 8, 2021
@google-cla google-cla bot added the cla: yes label Feb 8, 2021
@gbaned gbaned self-assigned this Feb 9, 2021
@gbaned gbaned added comp:keras Keras related issues prtype:bugfix PR to fix a bug labels Feb 9, 2021
@gbaned gbaned self-requested a review February 9, 2021 13:02
Copy link
Member

@qlzh727 qlzh727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM.

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Feb 9, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 9, 2021
@copybara-service copybara-service bot merged commit d7defae into tensorflow:master Feb 10, 2021
@yongtang yongtang deleted the 46993-tf.keras.layers.LeakyReLU-alpha-None branch February 10, 2021 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes comp:keras Keras related issues prtype:bugfix PR to fix a bug ready to pull PR ready for merge process size:S CL Change Size: Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tf.keras.layers.ELU and tf.keras.layers.LeakyReLU outputs nan if alpha=None

4 participants