[tf-mlir-translate] patch for handling data types with subtypes #55791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support to tf-mlir-translate and it's python wrapper for handling data types with subtypes
Mogball
suggested changes
May 2, 2022
tensorflow/compiler/mlir/tensorflow/translate/mlir_roundtrip_flags.cc
Outdated
Show resolved
Hide resolved
tensorflow/compiler/mlir/tensorflow/translate/mlir_roundtrip_flags.cc
Outdated
Show resolved
Hide resolved
tensorflow/compiler/mlir/tensorflow/translate/mlir_roundtrip_flags.cc
Outdated
Show resolved
Hide resolved
tensorflow/compiler/mlir/tensorflow/translate/mlir_roundtrip_flags.cc
Outdated
Show resolved
Hide resolved
tensorflow/compiler/mlir/tensorflow/translate/mlir_roundtrip_flags.cc
Outdated
Show resolved
Hide resolved
tensorflow/compiler/mlir/tensorflow/translate/mlir_roundtrip_flags.cc
Outdated
Show resolved
Hide resolved
tensorflow/compiler/mlir/tensorflow/translate/mlir_roundtrip_flags.cc
Outdated
Show resolved
Hide resolved
Mogball
suggested changes
May 3, 2022
tensorflow/compiler/mlir/tensorflow/translate/mlir_roundtrip_flags.cc
Outdated
Show resolved
Hide resolved
google-ml-butler
bot
added
kokoro:force-run
Mogball
approved these changes
May 5, 2022
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in this issue: #50521 (comment), tf-mlir-translate didn't have a mechanism for handling data type with subtypes such as DT_RESOURCE. This patch adds support for handling types that might have subtypes to tf-mlir-translate and it's python wrapper.