Add check that output is quantized. #1830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
emmett-google
left a comment
emmett-google
left a comment
There was a problem hiding this comment.
Suggestion to move the check into CalculateOpDataAdd but otherwise looks good!
| // This is to ensure that for int8/int16 output type,output does not have | ||
| // a "no-quantization" quantization type. | ||
| if (output->type == kTfLiteInt8 || output->type == kTfLiteInt16) { | ||
| TFLITE_CHECK_NE(output->quantization.type, kTfLiteNoQuantization); |
Collaborator
There was a problem hiding this comment.
I'd suggest moving this into CalculateOpDataAdd in Line 42 for a few long term maintenance reasons:
- The assert is closer to the code that assumes quantization.
- One fewer branch to maintain for checking output types. If someone extends the branch logic in
CalculateOpDataAdd, it will only need to be changed in on place.
Contributor
Author
There was a problem hiding this comment.
Thank you for the suggestion! Made the change.
advaitjain
reviewed
Mar 24, 2023
| data->requires_broadcast = !HaveSameShapes(input1, input2); | ||
|
|
||
| if (output->type == kTfLiteInt8 || output->type == kTfLiteInt16) { | ||
| // This is to ensure that for int8/int16 output type,output does not have |
Member
There was a problem hiding this comment.
Nit: Remove the comment. It's basically explaining the code.
advaitjain
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG=http://b/267818294