Fix core consistency test #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier for TensorLy to find the correct decomposition, which should make the test more robust.
Codecov Report
@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 95.08% 95.15% +0.06%
==========================================
Files 13 13
Lines 1464 1464
==========================================
+ Hits 1392 1393 +1
+ Misses 72 71 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15
We split the
test_core_element_plot_normalised_flagtest into two tests with better names, one for each of the scenarios it tested. For thepredictive_powerdoctest, we decreased the added noise and reduced the rank, which should make it easier for TensorLy to find the correct decomposition (and therefore easier for the test to pass).