Skip to content

Conversation

@cypher7682
Copy link

Description

Reverts a breaking change.

Motivation and Context

It makes it not a breaking change

Breaking Changes

It reverts a breaking change.

How Has This Been Tested?

It hasn't. It's for illustrative purposes / comment.

@cypher7682
Copy link
Author

This is relevant to #135

I've tested it my end, and it seems to work fine. But definitely worth someone else giving it a once over as I don't have private certs to import and test the NONE functionality through and through. The logic on the counts seems to work as expected though, and the certificate deploys.

DNS functionality also remains working.

@cypher7682 cypher7682 changed the title WIP: Revert BB change, make it backwards compatible Revert BB change, make it backwards compatible Oct 5, 2023
@charlierm
Copy link

This looks great @cypher7682 , looks like the semantic pr title is failing then hopefully good to go!

@antonbabenko
Copy link
Member

This issue has been resolved in version 5.0.0 🎉

@github-actions
Copy link

github-actions bot commented Nov 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants