fix: Matched type of extra certificate var in module to type expected in resource #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…expected in the module The `aws_lb_listener_certificate` resource expects the var to have fields `https_listener_index` and `certificate_arn`. Type `list(map(string)))` does not support passing in an object that sets these fields correctly Signed-off-by: Noah Krause <krausenoah@gmail.com>
iNoahNothing
changed the title
iNoahNothing
changed the title
iNoahNothing
changed the title
iNoahNothing
changed the title
|
@antonbabenko Anything else you need to see from me to land this? |
antonbabenko
approved these changes
Oct 28, 2022
antonbabenko
pushed a commit
that referenced
this pull request
Oct 28, 2022
### [8.1.1](v8.1.0...v8.1.1) (2022-10-28) ### Bug Fixes * Matched type of extra certificate var in module to type expected in resource ([#259](#259)) ([144af83](144af83))
|
This PR is included in version 8.1.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Noah Krause krausenoah@gmail.com
Description
The
aws_lb_listener_certificateresource expects the var to have fieldshttps_listener_indexandcertificate_arn. Typelist(map(string)))does not support passing in an object that sets these fields correctlyMotivation and Context
Currently, you cannot set
extra_ssl_certscorrectly since the type does not support setting the required fieldsBreaking Changes
None
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request