This fixes #57

[egarbi]

When modifying default tg the new one need to be created for listener be able to use it and terraform can destroy the old one later

[brandonjbjelland]

Hey again @egarbi . I'm wondering if this actually fixes the problem in #57 . Imagining a create_before_destroy scenario here, I'm wondering if name conflicts between the old and new target groups also raise errors (for instance if backend_port were the change). If you've tested your branch and making changes to the target group works, I'll go ahead with the test and merge.

[egarbi]

@brandoconnor you're right, this only fix the case when name changes, all other attributes will fail with:

aws_lb_target_group.main: Error creating LB Target Group: DuplicateTargetGroupName: A target group with the same name 'default-uat' exists, but with different settings

[egarbi]

@brandoconnor I would say this is better than nothing, With this, you can change at least name without this you can change nothing. I can figure now a permanent solution. Don't know mate, you're the expert here. It's up to you. Thanks for this module.

[brandonjbjelland]

The change is appreciated, I just think we need to be clear in the docs about the caveat and how to do a workaround.

I've vetted the change and added some extra bits to the docs and tests to incorporate it. Merging now.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.