Add slow_start option to target_group defs #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colindean
added a commit
to arcadia/terraform-aws-alb
that referenced
this pull request
Oct 26, 2018
Add slow_start option to target_group defs
|
ping @brandoconnor |
|
Apologies. I'm on vacation for the next couple weeks without a computer.
Will get back to this mid Nov.
…On Mon, Oct 29, 2018, 8:43 PM Jon Whitcraft ***@***.***> wrote:
ping @brandoconnor <https://github.com/brandoconnor>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACYveLP6WFAGANo6pl-YmSJjejlZVneoks5upwX0gaJpZM4XKL-7>
.
|
jwhitcraft
force-pushed
the
slow_start
branch
from
571d598 to
7b9843b
Compare
|
@brandoconnor I just updated this with the latest master? Any chance of a merge? |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR o'clock
Description
This adds support for
slow_startto the target_groups which fixes #86Checklist
terraform fmtandterraform validateboth work from the root andexamples/alb_test_fixturedirectories (look in CI for an example)