bug: enable_ephemeral_storage broken by update to support EFS to persist Atlantis state

[MarkIannucci]

Unfortunately this is not working if I want to have enable_ephemeral_storage=true

╷
│ Error: Invalid index
│ 
│   on .terraform/modules/atlantis/main.tf line 438, in resource "aws_efs_mount_target" "this":
│  438:   file_system_id  = aws_efs_file_system.this[0].id
│     ├────────────────
│     │ aws_efs_file_system.this is empty tuple
│ 
│ The given key does not identify an element in this collection value.
╵

there is no condition for var.enable_ephemeral_storage

Originally posted by @borissavelev in #247 (comment)

[MarkIannucci]

I'll look to correct this problem Thursday or Friday this week.

[bryantbiggs]

duplicate of #252

[borissavelev]

@bryantbiggs this one is not related to #252
And fix from #252 will not fix this issue

[bryantbiggs]

ah, I see - this is not conditionally blocked by a var.enable_ephemeral_storage

terraform-aws-atlantis/main.tf

Line 436 in 2df6bd6

for_each = zipmap(coalescelist(var.private_subnets, var.private_subnet_ids), local.private_subnet_ids)

[bryantbiggs]

whoever picks up this issue - we'll want to create a new example that has EFS enabled, and the current complete-github we can leave out EFS. Something like efs-github I guess. This lets us test both avenues and would have caught this issue

[antonbabenko]

It is so good to see you guys participating in this feature/bug resolution so I have made my first ever Terraform meme - https://twitter.com/antonbabenko/status/1493506138960273408

Thank you! 🚀

[jeff-clearcover]

@MarkIannucci did you pick this up? We may need to fix it in a fork to move forward, if you haven't or won't get to it this week we can open an upstream PR here.

[MarkIannucci]

@jeff-clearcover , yep. I've got some code which fixes this underway, I'll push and open a PR later tonight (after dinner with my family :-)

I am hoping to increase the example coverage a bit (adding one for VPC and a second for ephemeral storage)

[jeff-clearcover]

Woohoo, you rock @MarkIannucci thank you for the quick reply ... here to test and help as needed too!