Skip to content

Conversation

@hatemosphere
Copy link
Contributor

Description

This adds the ability to add extra loadbalancer blocks to the ECS task definition so that additional "sidecar" containers added via var.extra_container_definitions can be exposed as well on the same ALB

Motivation and Context

Expose Atlantis log streaming sidecar UI

Breaking Changes

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

@hatemosphere hatemosphere changed the title Adding ability to add extra loadbalancer blocks to ECS task feat: Adding ability to add extra loadbalancer blocks to ECS task Oct 30, 2021
@antonbabenko antonbabenko changed the title feat: Adding ability to add extra loadbalancer blocks to ECS task feat: Added ability to add extra loadbalancer blocks to ECS task Nov 1, 2021
@antonbabenko antonbabenko merged commit 4364a67 into terraform-aws-modules:master Nov 1, 2021
@antonbabenko
Copy link
Member

Thanks for the addition! 🎉

v3.4.0 has been just released.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants