feat: Allow CloudWatch Log Encryption and Default Security Group Management #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he default security group of the atlantis vpc
…ryption add the ability to optionally encrypt cloudwatch logs and to manage t…
fix readme to include new vars
antonbabenko
pushed a commit
that referenced
this pull request
Jan 19, 2022
## [3.8.0](v3.7.0...v3.8.0) (2022-01-19) ### Features * Allow CloudWatch Log Encryption and Default Security Group Management ([#246](#246)) ([6a27fff](6a27fff))
Member
|
This PR is included in version 3.8.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some optional variables.
cloudwatch_logs_kms_key_id, to encrypt the Cloudwatch Log Group created in the modulemanage_default_security_group, to allow the submoduleterraform-aws-modules/vpc/awsto manage the default security groupdefault_security_group_ingressanddefault_security_group_egressalso includedMotivation and Context
This change gives a few options to make the module friendly to the Config rule set we have set up in our AWS environment, which requires Cloudwatch Log Groups to be encrypted and default Security Groups to be closed.
Breaking Changes
No breaking changes. All new variables are optional
How Has This Been Tested?
We are using this in our own AWS environment.