feat: Added a possibility to allow private hosted zone usage

[jgerry]

Description

Add a new boolean variable route53_private_zone to pass into the ALB module

Motivation and Context

Add support for Route53 private hosted zones. Fixes #249.

Breaking Changes

no breaking changes

How Has This Been Tested?

• I have tested and validated these changes using one or more of the provided examples/* projects.

I have tested this by setting route53_zone_name to a public hosted zone, the module works as it did before my change. By setting route53_zone_name to a private hosted zone, and setting route53_private_zone to true, I was able to create the appropriate Route53 entry in my private hosted zone.

Terraform v1.1.4
on darwin_amd64
+ provider registry.terraform.io/hashicorp/aws v3.74.0
+ provider registry.terraform.io/hashicorp/local v2.1.0
+ provider registry.terraform.io/hashicorp/random v3.1.0

[antonbabenko]

LGTM, please fix the docs by running pre-commit run -a and committing the changes.

[bryantbiggs]

looks good, thanks @jgerry

@antonbabenko 👍🏽

[antonbabenko]

@bryantbiggs Now we have some more extra work with AWS provider version 4. For now, I just locked it to version 3.

[bryantbiggs]

Ya I just saw that dropped, I'll start taking a look later today 😅

[antonbabenko]

This PR is included in version 3.11.0 🎉

[alin-grecu]

Sorry if this is not a good place, but I think because of:

terraform-aws-atlantis/main.tf

Line 406 in 7803bcf

zone_id = var.certificate_arn == "" ? element(concat(data.aws_route53_zone.this.*.id, [""]), 0) : ""

and:

terraform-aws-atlantis/main.tf

Line 137 in 7803bcf

private_zone = var.route53_private_zone

if you set route53_private_zone = true AWS is unable to validate ACM because the validation record is created on a private zone.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.