Skip to content

feat: Add firehose args #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 4, 2022
Merged

feat: Add firehose args #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c6925f
add firehose args
edgarsandi Nov 19, 2022
0ad70c3
chore(doc): update README.md
edgarsandi Nov 19, 2022
b15eb4c
Apply suggestions from code review
bryantbiggs Dec 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ No modules.
| <a name="input_delivery_policy"></a> [delivery\_policy](#input\_delivery\_policy) | The SNS delivery policy | `string` | `null` | no |
| <a name="input_display_name"></a> [display\_name](#input\_display\_name) | The display name for the SNS topic | `string` | `null` | no |
| <a name="input_fifo_topic"></a> [fifo\_topic](#input\_fifo\_topic) | Boolean indicating whether or not to create a FIFO (first-in-first-out) topic | `bool` | `false` | no |
| <a name="input_firehose_failure_feedback_role_arn"></a> [firehose\_failure\_feedback\_role\_arn](#input\_firehose\_failure\_feedback\_role\_arn) | IAM role for failure feedback | `string` | `null` | no |
| <a name="input_firehose_success_feedback_role_arn"></a> [firehose\_success\_feedback\_role\_arn](#input\_firehose\_success\_feedback\_role\_arn) | The IAM role permitted to receive success feedback for this topic | `string` | `null` | no |
| <a name="input_firehose_success_feedback_sample_rate"></a> [firehose\_success\_feedback\_sample\_rate](#input\_firehose\_success\_feedback\_sample\_rate) | Percentage of success to sample | `number` | `null` | no |
| <a name="input_http_failure_feedback_role_arn"></a> [http\_failure\_feedback\_role\_arn](#input\_http\_failure\_feedback\_role\_arn) | IAM role for failure feedback | `string` | `null` | no |
| <a name="input_http_success_feedback_role_arn"></a> [http\_success\_feedback\_role\_arn](#input\_http\_success\_feedback\_role\_arn) | The IAM role permitted to receive success feedback for this topic | `string` | `null` | no |
| <a name="input_http_success_feedback_sample_rate"></a> [http\_success\_feedback\_sample\_rate](#input\_http\_success\_feedback\_sample\_rate) | Percentage of success to sample | `string` | `null` | no |
Expand Down
3 changes: 3 additions & 0 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ resource "aws_sns_topic" "this" {
application_success_feedback_role_arn = var.application_success_feedback_role_arn
application_success_feedback_sample_rate = var.application_success_feedback_sample_rate
application_failure_feedback_role_arn = var.application_failure_feedback_role_arn
firehose_success_feedback_role_arn = var.firehose_success_feedback_role_arn
firehose_success_feedback_sample_rate = var.firehose_success_feedback_sample_rate
firehose_failure_feedback_role_arn = var.firehose_failure_feedback_role_arn
http_success_feedback_role_arn = var.http_success_feedback_role_arn
http_success_feedback_sample_rate = var.http_success_feedback_sample_rate
http_failure_feedback_role_arn = var.http_failure_feedback_role_arn
Expand Down
18 changes: 18 additions & 0 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,24 @@ variable "application_failure_feedback_role_arn" {
default = null
}

variable "firehose_success_feedback_role_arn" {
description = "The IAM role permitted to receive success feedback for this topic"
type = string
default = null
}

variable "firehose_success_feedback_sample_rate" {
description = "Percentage of success to sample"
type = number
default = null
}

variable "firehose_failure_feedback_role_arn" {
description = "IAM role for failure feedback"
type = string
default = null
}

variable "http_success_feedback_role_arn" {
description = "The IAM role permitted to receive success feedback for this topic"
type = string
Expand Down