feat!: Add support for SNS topic filtering, subscriptions, and topic policy creation #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
opening as draft because I want to update SQS as well and make sure the two work well together for pub/sub architectures (avoid chicken vs egg or scenario when passing attributes from one to the other, etc.) |
3 tasks
Co-authored-by: Anton Babenko <anton@antonbabenko.com>
antonbabenko
pushed a commit
that referenced
this pull request
Jan 3, 2023
## [5.0.0](v4.1.0...v5.0.0) (2023-01-03) ### ⚠ BREAKING CHANGES * Add support for SNS topic filtering, subscriptions, and topic policy creation (#36) ### Features * Add support for SNS topic filtering, subscriptions, and topic policy creation ([#36](#36)) ([707b407](707b407)) ### Bug Fixes * Use a version for to avoid GitHub API rate limiting on CI workflows ([#39](#39)) ([117400e](117400e))
Member
|
This PR is included in version 5.0.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
create_sns_topichas been renamed tocreatepolicyhas been renamed totopic_policyname_prefixhas been replaced with the combination ofnameanduse_name_prefix = trueto ensure only one value is provided*_failure_feedback_role_arn,*_success_feedback_role_arn,*_success_feedback_sample_ratevariables have been replaced with a respective top level variable that contains a map to the three attributes. See before and after below for further clarification.sns_prefix stripped from their namesMotivation and Context
Breaking Changes
UPGRADE-5.0.mdguide providedHow Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request