-
-
Notifications
You must be signed in to change notification settings - Fork 90
feat: Configure cloudwatch logging for step functions module #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Configure cloudwatch logging for step functions module #9
Conversation
|
Looks like my IDE took some liberties reformatting the |
|
Actually the |
antonbabenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the code a bit.
|
@antonbabenko Addressed PR comments. Let me know if I've missed the mark on anything. |
|
Looking fwd to see this PR merged. |
|
Any chance this PR can be reviewed @antonbabenko? Looking forward to this being merged. |
|
@ahummel25 Could resolve the conflict, please? |
|
@svenlito Done. @antonbabenko I've resolved the merge conflicts, but not sure why the Pre-Commit hook is failing. Can you please advise? Passes all pre-commit checks locally. pre-commit run --color=always --show-diff-on-failure --all-files
Terraform fmt............................................................Passed
Terraform validate.......................................................Passed
Terraform docs...........................................................Passed
Terraform validate with tflint...........................................Passed
Check for merge conflicts................................................Passed |
|
@ahummel25 if you update the its the terraform docs that we are still unfortunately fighting with at the moment |
|
@bryantbiggs Just did so. Looks like it's still failing. Any ideas? |
|
I just ran |
|
thats correct, but I suspect that your local version of |
|
Thanks @bryantbiggs. That fixed it. |
6d5cfc2 to
ceea40d
Compare
|
Thanks @ahummel25 ! v1.3.0 has been just released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |

Description
Adding
logging_configurationproperty to enable Cloudwatch logging for step functionsMotivation and Context
Need ability to utilize Cloudwatch logging for step functions
Breaking Changes
How Has This Been Tested?
examples/*projects