fix: Add dependency on the Pub/Sub topic/subscription for tags examples #1152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es (#15589) Co-authored-by: Scott Suarez <ScottSuarez@google.com> [upstream:e557ee7da06142d40585af6d3457d210190e26f9] Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
merged commit fd4df52
into
terraform-google-modules:master
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a dependency on the Pub/Sub topic or subscription for tag keys and values to ensure that the Pub/Sub resource is cleaned up before deleting the tag.
Fixes hashicorp/terraform-provider-google#24926
Fixes hashicorp/terraform-provider-google#24930
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Derived from GoogleCloudPlatform/magic-modules#15589