Define root module

[aaron-lane]

This branch defines the root module. 🎉

[ocervell]

Looks good already. Any reason to not use https://github.com/terraform-google-modules/terraform-google-log-export for the log export ?

[aaron-lane]

@ocervell I avoided terraform-google-log-export because I had hit terraform-google-modules/terraform-google-log-export#10 in the past, but on further inspection, it probably won't affect this module so I'll test it out.

[aaron-lane]

@ocervell Testing revealed that terraform-google-modules/terraform-google-log-export#10 does affect this module so using log-export is not an option at the present.

[adrienthebo]

Review summary

Looks good, no blockers, I've a question or two and a few suggestions. Some questions regarding scoping might be too broad for this PR, so feel free to resolve those comments as you see fit.

Suggestions

• Consider adding a random suffix to the GCS bucket
• Consider dropping the name variable default value

Questions

• What event types do we intend to support for the v1 release of this module?
• What's the scope of the event function sources?

[adrienthebo]

I'm happy with this, 👍 for merge. CI is not passing but not because of any issues in this PR.

Integration tests look good locally:

Verifying automatic_labelling

Profile: automatic_labelling
Version: 0.1.0
Target:  gcp://project-factory-20712@thebo-host-c15e.iam.gserviceaccount.com

  ✔  automatically labelled: Instance unlabelled
     ✔  Instance unlabelled should be automatically labelled by the Cloud Functions function

There's one whitespace error in the inspec.yml, with a local fix everything else looks good:

╰─ make check
Running shellcheck
Running flake8
Running go fmt and go vet
Running terraform validate
terraform validate --check-variables=false .
terraform validate --check-variables=false ./examples/automatic_labelling
terraform validate --check-variables=false ./test/fixtures/automatic_labelling
Running hadolint on Dockerfiles
Checking for required files LICENSE README.md
Testing the validity of the header check
..
----------------------------------------------------------------------
Ran 2 tests in 0.038s

OK
Checking file headers
Checking for trailing whitespace

@aaron-lane do you want to shave the CI yak here, or shall we handle that in a new PR?

[adrienthebo]

Since this is functionally correct and I've verified it locally I'm going to merge it, and we can shave yaks later.