Skip to content

fix: set optional max_instances to default value for CI #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 6, 2023
Merged

fix: set optional max_instances to default value for CI #133

merged 2 commits into from
Jan 6, 2023

Conversation

@apeabody
Copy link
Contributor

@apeabody apeabody commented Dec 29, 2022 •
edited
Loading

@apeabody apeabody force-pushed the ap-patch-21gh branch 2 times, most recently from 62d0095 to a2daf3b Compare December 30, 2022 00:47
@apeabody apeabody changed the title fix: set optional max_instances to default null fix: set max_instances to default API value Dec 30, 2022
@apeabody apeabody changed the title fix: set max_instances to default API value fix: set max_instances in examples for CI Dec 30, 2022
@apeabody apeabody changed the title fix: set max_instances in examples for CI chore: set max_instances in examples for CI Dec 30, 2022
@apeabody apeabody force-pushed the ap-patch-21gh branch 7 times, most recently from 23836bf to 317270b Compare January 3, 2023 19:30
@apeabody apeabody changed the title chore: set max_instances in examples for CI chore: set optional max_instances to default value for CI Jan 3, 2023
@apeabody apeabody changed the title chore: set optional max_instances to default value for CI fix: set optional max_instances to default value for CI Jan 3, 2023
@apeabody apeabody marked this pull request as ready for review January 3, 2023 19:57
@apeabody apeabody requested a review from a team as a code owner January 3, 2023 19:57
@apeabody
Copy link
Contributor Author

apeabody commented Jan 4, 2023

@bharathkkb - Here is the revised version for the CI to work around hashicorp/terraform-provider-google#13263

g-awmalik
g-awmalik reviewed Jan 5, 2023
View reviewed changes
Copy link
Contributor

@g-awmalik g-awmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit on the provider.

@comment-bot-dev
Copy link

comment-bot-dev commented Jan 5, 2023

@apeabody
Thanks for the PR! 🚀
✅ Lint checks have passed.

@apeabody apeabody merged commit 63c98bd into master Jan 6, 2023
@apeabody apeabody deleted the ap-patch-21gh branch January 6, 2023 20:34
@release-please release-please bot mentioned this pull request Jan 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@g-awmalik g-awmalik g-awmalik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@apeabody @comment-bot-dev @g-awmalik