Redesign to use submodules #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit simplifies the composition of modules. The root module configures a function sourced from a directory on localhost. The function-sourced-from-repository submodule offers an alternative implementation which configures a function sourced from a repository. Events are composed as singular submodules to strike a balance between extensibility and ease of use.
aaron-lane
force-pushed
the
aaron-lane/submodules
branch
from
92f4c41 to
30d669d
Compare
Support for semantic versioning appears to be broken.
marko7460
reviewed
Apr 2, 2019
adrienthebo
reviewed
Apr 2, 2019
adrienthebo
approved these changes
Apr 2, 2019
Contributor
adrienthebo
left a comment
adrienthebo
left a comment
There was a problem hiding this comment.
LGTM, I've got a couple of non-blockers relating to names but this looks solid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root module configures a function sourced from a directory on
localhost. The function-sourced-from-repository submodule offers an
alternative implementation which configures a function sourced from a
repository.
Events are composed as singular submodules to strike a balance between
extensibility and ease of use.