-
Notifications
You must be signed in to change notification settings - Fork 66
Add Cloud Function that deletes VM instances created without CMEK. #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aaron-lane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified the Terraform configuration is functional, but could the example be extended with a noncompliant VM to prove the functionality without requiring the end users to add additional resources?
This sounds frustrating. Typically when I grab an example or tool I want it to work with as little configuration as possible. If I do this the end user has to cleanup the TF and remove this resource and any other dependencies. |
|
@aaron-lane I don't have the ability to assign this back to you |
Agreed. |
|
@zachberger Typically, examples should be as self-contained as possible. If this example has practical applications outside of demonstrating usage of the module then we should add it as a submodule so that it can be properly supported. |
|
This is exhausting. Ive been sent from repo to repo being told to contribute in different ways. At this point I don't even want to contribute this anymore. |
|
I'm reopening this because I concur with @zachberger that having an entire VM instance be part of the config just for a simple example is extraneous and unnecessary. As far as I am concerned, this PR is fine to merge as-is. |
morgante
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one tiny nit.
| } | ||
| } | ||
|
|
||
| func RecieveMessage(ctx context.Context, msg *pubsub.Message) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit. spelling (ReceiveMessage)
morgante
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny nit, but I am fine with merging as-is.
This Cloud Function detects newly created VM Instances that have disks attached
with a Google-managed encryption key attached and then immediately deletes
any such VM instances.