Begin to close the gap between this and scheduled-function #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings terraform-google-event-function in line with the input variables in line with terraform-google-scheduled-function. First step towards consolidation.
This continues to close the gap between event-function and scheduled-function. Scheduled-function has this set to true, but event function has set to false.
zachberger
requested review from
aaron-lane,
adrienthebo and
morgante
as code owners
Contributor
Author
|
After these changes, scheduled-function can be implemented using event-function |
zachberger
commented
Jun 19, 2019
aaron-lane
suggested changes
Jun 21, 2019
Contributor
aaron-lane
left a comment
aaron-lane
left a comment
There was a problem hiding this comment.
Thanks for being flexible with the implementation, @zachberger! A few questions and suggestions.
Co-Authored-By: Aaron Lane <aarondrewlane@gmail.com>
Contributor
Author
|
@aaron-lane what do you think about removing the default value for the cloud function's runtime? It seems like we'll need to update it frequently with the seemingly constant deprecations. I'm also not convinced |
Contributor
|
I'm okay with dropping the default; I just went with it since it was the default language in many CloudFunctions examples. |
Contributor
Author
|
What do you think about leaving refactoring |
Contributor
|
@zachberger sure, we can do that. |
aaron-lane
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.