-
Notifications
You must be signed in to change notification settings - Fork 66
Event function: update testing to new approach #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event function: update testing to new approach #29
Conversation
68e55e4 to
9975a02
Compare
|
@kopachevsky share please test results |
|
|
d927603 to
4d9b21e
Compare
To support zone and region params of examples added custom code to main.tf to get random available Fixes terraform-google-modules#26
d5de88b to
c9520c0
Compare
c9520c0 to
2ccf7a0
Compare
morgante
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor issues, also please make sure to remove legacy testing content from the README: https://github.com/terraform-google-modules/terraform-google-event-function/blame/master/README.md#L91-L188
2ccf7a0 to
88c7c3a
Compare
|
|
||
| name = local.project_name | ||
| random_project_id = false | ||
| auto_create_network = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be false; we don't want to rely on the default network.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the reason I've added true, please advice how to address this it proper way without default networks
terraform-google-event-function/examples/automatic-labelling-from-localhost/main.tf
Lines 92 to 94 in 32a9ef5
| network_interface { | |
| network = "default" | |
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies; that's a fair point. I've created #33 to track this change separately.
Added Region and Zone variable for test/setup/variables.tf required to run example terraform files during testing. Fixes terraform-google-modules#26
88c7c3a to
a111499
Compare
|
|
||
| name = local.project_name | ||
| random_project_id = false | ||
| auto_create_network = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies; that's a fair point. I've created #33 to track this change separately.
To support zone and region params of examples added custom code to main.tf to get random available
Fixes #26