Skip to content

Conversation

@kopachevsky
Copy link
Contributor

To support zone and region params of examples added custom code to main.tf to get random available

Fixes #26

@kopachevsky kopachevsky force-pushed the fix/26/event-function branch 2 times, most recently from 68e55e4 to 9975a02 Compare September 9, 2019 15:55
@paulpalamarchuk
Copy link

@kopachevsky share please test results

@kopachevsky
Copy link
Contributor Author

@paulpalamarchuk

Step #4 - "verify": automatic-labelling: Verifying
Step #4 - "verify": 
Step #4 - "verify": Profile: automatic_labelling
Step #4 - "verify": Version: 0.1.0
Step #4 - "verify": Target:  gcp://ci-account@ci-event-function-1a045964.iam.gserviceaccount.com
Step #4 - "verify": 
Step #4 - "verify":   ✔  automatically labelled: Instance unlabelled-humane-llama
Step #4 - "verify":      ✔  Instance unlabelled-humane-llama should be automatically labelled by the Cloud Functions function
Step #4 - "verify": 

@kopachevsky
Copy link
Contributor Author

Step #5 - "destroy":        Deleted workspace "kitchen-terraform-automatic-labelling-from-repository"!
Step #5 - "destroy":        Finished destroying <automatic-labelling-from-repository> (1m9.40s).
Step #5 - "destroy": -----> Kitchen is finished. (2m44.04s)
Finished Step #5 - "destroy"
2019/09/10 11:34:23 Step Step #5 - "destroy" finished
2019/09/10 11:34:23 status changed to "DONE"
DONE

@kopachevsky kopachevsky force-pushed the fix/26/event-function branch 2 times, most recently from d927603 to 4d9b21e Compare September 11, 2019 10:44
To support zone and region params of examples added custom code to main.tf to get random available

Fixes terraform-google-modules#26
@kopachevsky kopachevsky force-pushed the fix/26/event-function branch 2 times, most recently from d5de88b to c9520c0 Compare September 11, 2019 16:16
@paulpalamarchuk paulpalamarchuk self-requested a review September 11, 2019 16:20
@kopachevsky kopachevsky marked this pull request as ready for review September 12, 2019 18:50
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor issues, also please make sure to remove legacy testing content from the README: https://github.com/terraform-google-modules/terraform-google-event-function/blame/master/README.md#L91-L188

@aaron-lane aaron-lane added the enhancement New feature or request label Sep 16, 2019

name = local.project_name
random_project_id = false
auto_create_network = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be false; we don't want to rely on the default network.

Copy link
Contributor Author

@kopachevsky kopachevsky Sep 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the reason I've added true, please advice how to address this it proper way without default networks

network_interface {
network = "default"
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies; that's a fair point. I've created #33 to track this change separately.

Added Region and Zone variable for test/setup/variables.tf required to run example terraform files during testing.

Fixes terraform-google-modules#26

name = local.project_name
random_project_id = false
auto_create_network = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies; that's a fair point. I've created #33 to track this change separately.

@aaron-lane aaron-lane merged commit 6d48307 into terraform-google-modules:master Sep 23, 2019
averbuks added a commit to averbuks/terraform-google-event-function that referenced this pull request Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update testing to new approach

5 participants