Skip to content

Code review fixes for: Add example and tests for project-related events #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2019
Merged

Code review fixes for: Add example and tests for project-related events #34

merged 1 commit into from
Oct 15, 2019

Conversation

@kopachevsky
Copy link
Contributor

@kopachevsky kopachevsky commented Oct 10, 2019

Example and tests for automatic project labeling.
Changed setup tf fixtures, sub folder creation added.

Relevant issues:
terraform-google-modules/terraform-google-vpc-service-controls#11
#27

Fixes #30

@kopachevsky kopachevsky force-pushed the feature/30/project-events branch from a8c93ff to b800956 Compare October 10, 2019 14:26
@nick4fake @kopachevsky
Code review fixes for: Add example and tests for project-related events
a8ded77 
Example and tests for automatic project labeling.
Changed setup tf fixtures, sub folder creation added.
Added roles/owner to cloud function sa for subfolder.

Relevant issues:
terraform-google-modules/terraform-google-vpc-service-controls#11
terraform-google-modules#27

Fixes terraform-google-modules#30
@kopachevsky kopachevsky force-pushed the feature/30/project-events branch from b800956 to a8ded77 Compare October 10, 2019 14:37
@kopachevsky kopachevsky self-assigned this Oct 10, 2019
@kopachevsky kopachevsky marked this pull request as ready for review October 11, 2019 13:29
@kopachevsky
Copy link
Contributor Author

kopachevsky commented Oct 11, 2019

couple comments for reviewers:

  • gcp project created as terraform resource during folder event tests @aaron-lane suggested to do not bother migrate it to project factory form
  • to attach label to the project mentioned above by cloud function, I've attaching project owner role to folder not for project, otherwise race condition appears: cloud function start processing project event right after project created by TF and before corresponding IAM resource been created by TF

@aaron-lane aaron-lane mentioned this pull request Oct 11, 2019
Closed
@morgante morgante assigned aaron-lane and unassigned kopachevsky Oct 11, 2019
@aaron-lane aaron-lane added the enhancement New feature or request label Oct 14, 2019
@morgante morgante merged commit f2bb448 into terraform-google-modules:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaron-lane aaron-lane Awaiting requested review from aaron-lane

@adrienthebo adrienthebo Awaiting requested review from adrienthebo

2 more reviewers

@morgante morgante morgante approved these changes

@paulpalamarchuk paulpalamarchuk paulpalamarchuk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kopachevsky kopachevsky

@aaron-lane aaron-lane

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add example and tests for project-related events

5 participants

@kopachevsky @morgante @paulpalamarchuk @aaron-lane @nick4fake