Adding the include_children option #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sources. Keeping default to "false", so it is backwards compatible. No changes needed for existing implementations.
apsureda
requested review from
aaron-lane,
adrienthebo and
morgante
as code owners
morgante
approved these changes
Jan 6, 2020
Contributor
morgante
left a comment
morgante
left a comment
There was a problem hiding this comment.
Thanks for the addition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use this module to trigger a Cloud Function when a particular event happens in projects inside a folder, but the current implementation does not expose the include_children option of the terraform-google-modules/log-export/google module.
I have added this option as a variable, keeping the current value as default, so no changes will be needed in existing consumers of this module.