Skip to content

Conversation

@kpeder
Copy link
Contributor

@kpeder kpeder commented May 27, 2020

Supports a scenario where function archive sources are place on an existing bucket.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Just some nits I saw.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgante morgante merged commit 7ec5539 into terraform-google-modules:master May 28, 2020
@kpeder kpeder deleted the feature/use-existing-bucket branch May 28, 2020 14:16
@kpeder
Copy link
Contributor Author

kpeder commented May 28, 2020

Thanks v. much... any chance of a release tag soon-ish?

v1.2.0...master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants