Adding trigger_http input #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathkkb
requested changes
Nov 17, 2020
Member
bharathkkb
left a comment
bharathkkb
left a comment
There was a problem hiding this comment.
Thanks for the PR! We may need to set it trigger_http to null as CI given an error which I suspect is due to trigger_http = false and event_trigger block being present.
module.automatic_labelling_from_localhost.module.event_project_log_entry.google_pubsub_topic_iam_member.main: Creating...
module.automatic_labelling_from_localhost.module.event_project_log_entry.google_pubsub_topic_iam_member.main: Creation complete after 4s [id=projects/ci-event-function-9402/topics/infinite-alpaca/roles/pubsub.publisher/serviceaccount:p771980061706-101280@gcp-sa-logging.iam.gserviceaccount.com]
Error: ConflictsWith
on ../../../main.tf line 70, in resource "google_cloudfunctions_function" "main":
70: resource "google_cloudfunctions_function" "main" {
"event_trigger": conflicts with trigger_http
Contributor
Author
|
Sorry for the delay. I have modify the code as you requested. Please review it and let me know if there is something else needed. |
jtyr
force-pushed
the
jtyr-trigger_http
branch
from
b731b23 to
dd135ae
Compare
Contributor
Author
|
@bharathkkb please could you review this? |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
Member
|
/gcbrun |
|
Thanks for the PR! 🚀 |
Contributor
Author
|
@bharathkkb Please review the PR. |
bharathkkb
approved these changes
Mar 20, 2021
Member
|
Thanks @jtyr and apologies for missing this earlier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding an extra input called
trigger_httpwhich allows to create a function which is triggered by any HTTP request. This makes the previously required inputevent_triggeroptional as only one of them can be used at a time.