Skip to content

Add Serverless VPC Connector support for the Cloud Function #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2020
Merged

Add Serverless VPC Connector support for the Cloud Function #57

merged 1 commit into from
Nov 25, 2020

Conversation

@cleibl
Copy link

@cleibl cleibl commented Nov 25, 2020

Adding vpc_connector support for the Cloud Function. This should resolve #55

bharathkkb
bharathkkb approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM

@bharathkkb bharathkkb merged commit 3bea370 into terraform-google-modules:master Nov 25, 2020
@bharathkkb bharathkkb mentioned this pull request Dec 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@adrienthebo adrienthebo Awaiting requested review from adrienthebo

@morgante morgante Awaiting requested review from morgante

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for vpc_connector

2 participants

@cleibl @bharathkkb