Adds optional input 'max_instances' #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kpeder
commented
Nov 25, 2020
kpeder
commented
- Exposes max_instances on the google_cloudfunctions_function.
- Defaulted to 0, resulting in a noop for existing instances where the input is omitted.
- Setting is useful for resolving API or application throttling issues due to high execution rates.
- Corrects string substitution syntax, deprecated in terraform 0.13+
- Updates docs.
Contributor
Author
|
@adrienthebo is there an issue with triggers here? All the local tests passed fine, and the usual lint / integration tests. |
Member
|
@kpeder thanks for the PR. You can ignore those checks, it is a cloud build bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.