Log bucket #80
Merged
Log bucket #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🚀 |
Contributor
Author
|
@morgante Hi, you can me in approve please |
morgante
suggested changes
Oct 25, 2021
main.tf
Outdated
| labels = var.bucket_labels | ||
| uniform_bucket_level_access = true | ||
|
|
||
| logging { |
Contributor
There was a problem hiding this comment.
Please make this block conditional (so it's only added if log_bucket is not null).
Contributor
Author
There was a problem hiding this comment.
sure? log_bucket and log_object_prefix can be null
Contributor
There was a problem hiding this comment.
If log_bucket is null we don't want to add this block at all.
Contributor
Author
There was a problem hiding this comment.
i believe this good now
morgante
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please acepte merge, i need configure log bucket