Skip to content

chore: Generate output types for sql modules metadata.yaml files #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2024
Merged

chore: Generate output types for sql modules metadata.yaml files #654

merged 3 commits into from
Oct 10, 2024

Conversation

@tjy9206
Copy link
Contributor

@tjy9206 tjy9206 commented Oct 4, 2024

No description provided.

@tjy9206 tjy9206 marked this pull request as ready for review October 4, 2024 21:57
@tjy9206 tjy9206 requested review from a team, imrannayer and isaurabhuttam as code owners October 4, 2024 21:57
@tjy9206 tjy9206 changed the title chore: Generate output types for postgresql metadata.yaml. chore: Generate output types for sql modules metadata.yaml files Oct 5, 2024
q2w
q2w approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@q2w q2w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjy9206 If one runs cft blueprint metadata without generate-output-type flag, would the type info be removed?

@tjy9206
Copy link
Contributor Author

tjy9206 commented Oct 8, 2024

@tjy9206 If one runs cft blueprint metadata without generate-output-type flag, would the type info be removed?

It will actually remove the output types without -g flag. Do we want to preserve the fields? If so I can modify the tool for that.

@q2w
Copy link
Collaborator

q2w commented Oct 8, 2024

ant to preserve t

Yes. Let's preserve the fields!

@bharathkkb bharathkkb merged commit 0d6653b into terraform-google-modules:master Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@q2w q2w q2w approved these changes

@isaurabhuttam isaurabhuttam Awaiting requested review from isaurabhuttam

@imrannayer imrannayer Awaiting requested review from imrannayer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tjy9206 @q2w @bharathkkb