Skip to content

Hardcode disable option as it is not valid for postgres #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Hardcode disable option as it is not valid for postgres #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions examples/postgresql-ha/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,8 @@ module "pg" {
}

backup_configuration = {
enabled = true
binary_log_enabled = false
start_time = "20:55"
enabled = true
start_time = "20:55"
}

// Read replica configurations
Expand Down
2 changes: 1 addition & 1 deletion modules/postgresql/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ resource "google_sql_database_instance" "default" {
dynamic "backup_configuration" {
for_each = [var.backup_configuration]
content {
binary_log_enabled = lookup(backup_configuration.value, "binary_log_enabled", null)
binary_log_enabled = false
enabled = lookup(backup_configuration.value, "enabled", null)
start_time = lookup(backup_configuration.value, "start_time", null)
}
Expand Down
11 changes: 4 additions & 7 deletions modules/postgresql/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,18 +119,15 @@ variable "user_labels" {
variable "backup_configuration" {
description = "The backup_configuration settings subblock for the database setings"
type = object({
binary_log_enabled = bool
enabled = bool
start_time = string
enabled = bool
start_time = string
})
default = {
binary_log_enabled = null
enabled = false
start_time = null
enabled = false
start_time = null
}
}


variable "authorized_gae_applications" {
description = "The authorized gae applications for the Cloud SQL instances"
type = list(string)
Expand Down